Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasmtime: 0.15.0 -> 0.16.0 #87921

Merged
merged 2 commits into from May 16, 2020
Merged

wasmtime: 0.15.0 -> 0.16.0 #87921

merged 2 commits into from May 16, 2020

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented May 16, 2020 •
edited

Motivation for this change

Get all the goodness from the new release!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ggreif
Copy link
Contributor Author

ggreif commented May 16, 2020

@GrahamcOfBorg build wasmtime

@ofborg ofborg bot requested a review from matthewbauer May 16, 2020 02:46
@ggreif
Copy link
Contributor Author

ggreif commented May 16, 2020

@nomeata this has the DWARF-5 fixes.

@marsam
Copy link
Contributor

marsam commented May 16, 2020

@GrahamcOfBorg eval

@marsam
Copy link
Contributor

marsam commented May 16, 2020

@GrahamcOfBorg build wasmtime

@marsam marsam merged commit 033267e into NixOS:master May 16, 2020
@ggreif ggreif deleted the wasmtime branch May 17, 2020 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ggreif @marsam