Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] megasync 4.2.3.0 -> 4.3.0.9 (backport) #87901

Merged
merged 3 commits into from May 16, 2020
Merged

[20.03] megasync 4.2.3.0 -> 4.3.0.9 (backport) #87901

merged 3 commits into from May 16, 2020

Conversation

lunik1
Copy link
Contributor

@lunik1 lunik1 commented May 15, 2020

Motivation for this change

Megasync does not currently build on 20.03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Synthetica9 @lunik1
megasync: format with nixfmt
fd6368a 
(cherry picked from commit 5e55ebb)
@Synthetica9 @lunik1
megasync: 4.2.3.0 -> 4.2.5.0
79160c7 
Also pull in an (as of yet unmerged) upstream patch to fix
the build, it was failing on both .3 and .5

(cherry picked from commit 080a6b0)
@Synthetica9 @lunik1
megasync: 4.2.5.0 -> 4.3.0.8
2a83fa4 
(cherry picked from commit 8565dcf)
@ofborg ofborg bot requested a review from michojel May 15, 2020 16:47
michojel
michojel approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@michojel michojel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
built and tested

@marsam marsam merged commit 8c1977c into NixOS:release-20.03 May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michojel michojel michojel approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lunik1 @michojel @marsam @Janik-Haag @Synthetica9