Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go_1_13: 1.13.8 -> 1.13.11, stop setting GOPATH #87913

Merged
merged 2 commits into from May 16, 2020
Merged

go_1_13: 1.13.8 -> 1.13.11, stop setting GOPATH #87913

merged 2 commits into from May 16, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented May 16, 2020

This hook is removed in a1e13f6 on staging.

cc @Mic92 @zimbatm

@zowoq
Copy link
Contributor Author

zowoq commented May 16, 2020

I'll bump it to 1.13.11 as well while we're here.

@cole-h
Copy link
Member

cole-h commented May 16, 2020 •
edited

The hook is removed only in staging because it causes lots of rebuilds (which is what staging is for). It will make its way into master eventually.

EDIT: #87758

I was mistaken :D

@zowoq
Copy link
Contributor Author

zowoq commented May 16, 2020

When staging merges to master go_1_13 will break as it was readded after the hook was deleted.

@zowoq zowoq changed the title go: stop setting GOPATH go_1_13: 1.13.8 -> 1.13.11, stop setting GOPATH May 16, 2020
@ofborg ofborg bot requested review from Frostman, kalbasit, cstrahan and Mic92 May 16, 2020 00:34
@cole-h
Copy link
Member

cole-h commented May 16, 2020

I missed that this was for 1.13, oops.

I thought this would have a large amount rebuilds, but I remembered we migrated away from 1.13 (so nothing should be depending on a previously-removed package...). You're right; thanks for correcting me!

@zimbatm zimbatm merged commit 9fbb82f into NixOS:master May 16, 2020
@zowoq zowoq deleted the go113 branch May 16, 2020 10:47
@deviant deviant mentioned this pull request Sep 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frostman Frostman Awaiting requested review from Frostman

@kalbasit kalbasit Awaiting requested review from kalbasit kalbasit is a code owner

@cstrahan cstrahan Awaiting requested review from cstrahan

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @cole-h @zimbatm