fly: 6.0.0 -> 6.1.0 #87885
Merged
fly: 6.0.0 -> 6.1.0 #87885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to ship the pre-generated completions in the nixpkgs tree anymore.
milibopp
suggested changes
May 15, 2020
There was a problem hiding this comment.
Reviewed points
- package name fits guidelines
- package version fits guidelines
- package build on x86_64, NixOS fails
- executables tested on x86_64, NixOS fails
- all depending packages build
Possible improvements
Comments
As commented in the code the vendorSha256 hash is all zeros, which has to be changed to the actual hash of the vendored dependencies.
milibopp
approved these changes
May 15, 2020
There was a problem hiding this comment.
Reviewed points
- package name fits guidelines
- package version fits guidelines
- package build on x86_64, NixOS
- executables tested on x86_64, NixOS
- all depending packages build
Possible improvements
none
Comments
Now it's all good! :)
I checked execution of fly on its own and the completion functionality specifically both in zsh and bash like that:
source <(fly completion --shell zsh)
fly <TAB>and I get a nice list of commands as completions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This bumps fly to the latest release, containing various fixes as described in https://github.com/concourse/concourse/releases/tag/v6.1.0.
We also stop shipping the bash completions in the nixpkgs tree and generate them during the build, as concourse/concourse#4012 was merged.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)