This repository was archived by the owner on Apr 12, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 104
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7829e5791ba1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a7c70f2e10bc
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 13 commits
- 9 files changed
- 11 contributors
Commits on May 7, 2020
-
Johan Thomsen committed
May 7, 2020 Configuration menu - View commit details
-
Copy full SHA for 6b10ceb - Browse repository at this point
Copy the full SHA 6b10cebView commit details
Commits on May 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9c2fa3c - Browse repository at this point
Copy the full SHA 9c2fa3cView commit details -
firefox: Add patch to fix AES GCM IV bit size
Regression introduced by bce5268. The bit size of the initialisation vector for AES GCM has been introduced in NSS version 3.52 in the CK_GCM_PARMS struct via the ulIvBits field. Unfortunately, Firefox 68.8.0 and 76.0 do not set this field and thus it gets initialised to zero, which in turn causes IV generation to fail. I found out about this because WebRTC stopped working after updating to NSS 3.52 and so I started bisecting. Since there wasn't an obvious error in Firefox hinting towards NSS but instead just the video stream ended up as a "null" stream, I didn't suspect the NSS update to be the culprit at first. So I verified a few times and then also started bisecting the actual commit in NSS that caused the issue. This turned out to be the problematic change: https://phabricator.services.mozilla.com/D63241 > One notable change was caused by an inconsistancy between the spec and > the released headers in PKCS#11 v2.40. CK_GCM_PARAMS had an extra > field in the header that was not in the spec. OASIS considers the > header file to be normative, so PKCS#11 v3.0 resolved the issue in > favor of the header file definition. Since the test I've used[1] was a bit flaky, I still didn't believe the result of the bisect to be accurate, but after running the test several times leading same results I dug through the above change line by line to get more clues. It fortunately didn't take that long to stumble upon the ulIvBits change (which is actually documented in the NSS 3.52 release notes[4], but I managed to blatantly ignore it for some reason) and started checking the Firefox source tree for changes regarding that field. Initialisation of that new field has been introduced[2] in preparation for the 76 release, but subsequently got reverted[3] prior to the release, because Firefox 76 is expected to be shipped with NSS 3.51, which didn't have the ulIvBits field. The patch I'm adding here is just a reintroduction of that change, because we're using NSS 3.52. Not initialising that field will break WebRTC and WebCrypto, which I think the former seems to gain in popularity these days ;-) Tested the change against the mentioned VM test[1] and also by testing manually using Jitsi Meet and Nextcloud Talk. [1]: https://github.com/aszlig/avonc/tree/884315838b6f0ebb32b/tests/talk [2]: https://hg.mozilla.org/mozilla-central/rev/3ed30e6b6de1 [3]: https://hg.mozilla.org/mozilla-central/rev/665137da70ee [4]: https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.52_release_notes Signed-off-by: aszlig <aszlig@nix.build> (cherry picked from commit 8fb4997 & moved to packages.nix)
Configuration menu - View commit details
-
Copy full SHA for 89e9308 - Browse repository at this point
Copy the full SHA 89e9308View commit details
Commits on May 14, 2020
-
Merge pull request #87746 from zaninime/sane-update-20.03
backport: sane-airscan: 0.9.17 -> 0.99.0
Configuration menu - View commit details
-
Copy full SHA for 38ac9ed - Browse repository at this point
Copy the full SHA 38ac9edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f99408 - Browse repository at this point
Copy the full SHA 1f99408View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb59d52 - Browse repository at this point
Copy the full SHA cb59d52View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1dff047 - Browse repository at this point
Copy the full SHA 1dff047View commit details -
Merge #87773: firefox: patch AES GCM IV bit size
...into release-20.03
Configuration menu - View commit details
-
Copy full SHA for d2b0a72 - Browse repository at this point
Copy the full SHA d2b0a72View commit details -
(cherry picked from commit 2c9cc36)
Configuration menu - View commit details
-
Copy full SHA for 8830bd8 - Browse repository at this point
Copy the full SHA 8830bd8View commit details -
(cherry picked from commit c339130) This update should fix several bugs introduced in R48.
Configuration menu - View commit details
-
Copy full SHA for e3e62d6 - Browse repository at this point
Copy the full SHA e3e62d6View commit details -
mkl: fix expectation of MKLROOT being set in pkg-config files
The Intel MKL pkg-config files did not work, because they expect that the MKLROOT environment variable is set. This change replaces occurences by the actual path of MKL in the Nix store. Since the pkg-config files seem to break quite frequently after upgrades, add a post-install check to validate the pkg-config files. (cherry picked from commit e88673a)
Configuration menu - View commit details
-
Copy full SHA for 2dd4f2a - Browse repository at this point
Copy the full SHA 2dd4f2aView commit details -
Merge pull request #87749 from johanot/kubernetes-1.17.5
kubernetes: 1.17.3 -> 1.17.5
Configuration menu - View commit details
-
Copy full SHA for 5256f59 - Browse repository at this point
Copy the full SHA 5256f59View commit details -
Merge pull request #87836 from danieldk/mkl-pkgconfig-20.03
[20.03] mkl: fix expectation of MKLROOT being set in pkg-config files
Configuration menu - View commit details
-
Copy full SHA for a7c70f2 - Browse repository at this point
Copy the full SHA a7c70f2View commit details
There are no files selected for viewing