Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCS burns in editor are incorrect for multi-port thrusters #2571

Closed
RCrockford opened this issue May 15, 2020 · 0 comments · Fixed by #2651
Closed

RCS burns in editor are incorrect for multi-port thrusters #2571

RCrockford opened this issue May 15, 2020 · 0 comments · Fixed by #2651
Milestone

Comments

@RCrockford
Copy link
Contributor

RCrockford commented May 15, 2020

In

-transform.up))).Average()).

Thrusts are averaged across all thrust transforms.
For an N port thruster this will tend to give a resulting thrust of maxthrust/N assuming all ports are orthogonal, or some intermediate value otherwise.
Thrusters can actually deliver maxthrust down any single port so the statement should return the sum of positive thrusts rather than the average.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants