Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asciidoctor: add asciidoctor-bibliography #87882

Closed
wants to merge 2 commits into from
Closed

asciidoctor: add asciidoctor-bibliography #87882

wants to merge 2 commits into from

Conversation

Twey
Copy link
Contributor

@Twey Twey commented May 15, 2020

(change via bundix)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@evils
Copy link
Member

evils commented May 15, 2020

this should probably be merged to staging (i'm switching my #87646 to that now)

i haven't tried the result, but since i think closure size was a concern for NixOS/rfcs#64, this takes asciidoctor's nix path-info -S from 337247856 to 374326416

@evils
Copy link
Member

evils commented May 15, 2020

apparently i spoke too soon and staging is recommended for PRs that rebuild >1000 packages

@Twey
Copy link
Contributor Author

Twey commented Jun 8, 2020

So should this be onto staging? 🤔

@evils
Copy link
Member

evils commented Jun 8, 2020

So should this be onto staging?

i've been told otherwise
i was thinking it may be useful to not rebuild the dependents twice
but my PR is separate enough from this that they're not likely to be merged around the same time anyway

@Twey
Copy link
Contributor Author

Twey commented Jun 16, 2020

Great :)

@SuperSandro2000
Copy link
Member

This does not need to go trough staging.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 87882 run on x86_64-darwin 1

8 packages marked as broken and skipped:
  • almanah
  • atom
  • atom-beta
  • btrbk
  • gnome-recipes
  • gnome3.nautilus-python
  • mate.mate-utils
  • udiskie
9 packages built:
  • asciidoctor
  • bat-extras.batgrep
  • esh
  • newsboat
  • ripgrep
  • ripgrep-all
  • styx
  • weechat
  • weechat-unwrapped

@stale
Copy link

stale bot commented Jul 20, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 20, 2021
@FlorianFranzen
Copy link
Contributor

This should probably now go to the version with extensions.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Feb 1, 2022
@FlorianFranzen FlorianFranzen mentioned this pull request Feb 1, 2022
Merged
13 tasks
SuperSandro2000
SuperSandro2000 reviewed Feb 1, 2022
View reviewed changes
pkgs/tools/typesetting/asciidoctor/Gemfile.lock
@@ -93,4 +116,4 @@ DEPENDENCIES
rouge

BUNDLED WITH
2.1.4
1.17.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1.17.3
2.1.4

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Feb 1, 2022 •
edited

Closing due to being stale. Please create a new PR in the asciidoctor-with-extensions style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
2.status: merge conflict 8.has: documentation 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Twey @evils @SuperSandro2000 @FlorianFranzen