Fix #8131: small bridges also have pillars drawn #8149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your git config appears to be "broken" - the author of the commit is not linked to your GitHub account. Can you fix this? |
ilayaraja97
force-pushed
the
fix-8131
branch
2 times, most recently
from
3a98c6b
to
4e247d9
Compare
|
I wonder why it was special cased to begin with - there must have been a reason for it at some point, but it dates back further than the history shows - Lines 1106 to 1116 in efaeb27 |
|
This is strange. On azure pipelines the check is complete. In github the check is yet to complete. |
LordAro
approved these changes
Jun 28, 2020
LordAro
added
the
backport requested
glx22
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #8131
I have basically removed the code to draw poles below for small bridges as a ground sprite using
DrawGroundSpriteAt().Instead all pillions of bridges will be drawn by
DrawBridgePillars()I am unsure of what all this will break. Please give me some scenarios to test with. I have played around with this and doesn't break the game for me.