Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pulseaudio: enable soxr (resampler) support #87889

Merged
merged 1 commit into from May 24, 2020
Merged

pulseaudio: enable soxr (resampler) support #87889

merged 1 commit into from May 24, 2020

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented May 15, 2020

Motivation for this change

Support for additional resamplers.

Things done

Been running this on my system for a good while. The closure size increase is marginal (79.1M → 79.4M).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from lovek323 May 15, 2020 12:51
@pbogdan pbogdan changed the base branch from master to staging May 15, 2020 12:58
@pbogdan
Copy link
Member Author

pbogdan commented May 15, 2020

@GrahamcOfBorg eval

emilazy
emilazy approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'd wondered about the unavailability of these before.

@adisbladis adisbladis merged commit 4a5a9d2 into NixOS:staging May 24, 2020
@pbogdan pbogdan deleted the pa-soxr branch May 24, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@emilazy emilazy emilazy approved these changes

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pbogdan @bjornfor @emilazy @adisbladis