Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services/calibre-server: Allow multiple libraries, add "user" and "group" options #87912

Merged
merged 1 commit into from Sep 17, 2020
Merged

services/calibre-server: Allow multiple libraries, add "user" and "group" options #87912

merged 1 commit into from Sep 17, 2020

Conversation

loewenheim
Copy link
Contributor

Motivation for this change
  • Enabled more than one library directory. The option has been renamed from libraryDir to libraries. The motivation for this is simply that calibre-server supports it and I would like to have it.
  • There are now options to set the user and group the server should run under. If the standard user calibre-server is used, a home directory is created for it at /var/lib/calibre-server. The motivation for this change is the fact that there is currently no documentation about the user the server will run under and how this interacts with the library directory, as well as the fact that other similar server modules support setting the user and group.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@loewenheim
Copy link
Contributor Author

CC @domenkozar, @pSub, @AndersonTorres

@loewenheim loewenheim force-pushed the calibre-server branch 3 times, most recently from f651ada to 2a831e5 Compare September 11, 2020 15:29
@AndersonTorres
Copy link
Member

Looks good to me. I will merge tomorrow.

nixos/calibre-server: Allow multiple libraries
4560d7e 
Also add options for group and user.
@AndersonTorres AndersonTorres merged commit d50881e into NixOS:master Sep 17, 2020
@loewenheim loewenheim deleted the calibre-server branch September 21, 2020 10:13
@loewenheim loewenheim mentioned this pull request Oct 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenkozar domenkozar Awaiting requested review from domenkozar

@pSub pSub Awaiting requested review from pSub

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loewenheim @AndersonTorres