Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added Spanish town names #8152

Closed
wants to merge 1 commit into from
Closed

Conversation

rasputino
Copy link

I added Spanish (from Spain) town names with its own town name generator. I did the differentiation of Latinamerican and Spanish cities.

I think I fixed the validation problems from the last PR.

I know that you're generally opposed to adding further town name generators instead a NewGRFs. But I think is important to reflect in the program a big country like Spain as a default option like many others town name generators.

2020-05-14 11_03_27-Window

@James103
Copy link
Contributor

It is not recommended to PR from the master (or other default) branch of your repository. Instead, you should create a branch in your repository, move the changes there, and then open a pull request.

@rasputino rasputino marked this pull request as ready for review May 15, 2020 22:13
@rasputino
Copy link
Author

It is not recommended to PR from the master (or other default) branch of your repository. Instead, you should create a branch in your repository, move the changes there, and then open a pull request.

Ok, I'll do it in that way next time. Thanks for your advice

@telk5093
Copy link
Contributor

As I know, adding a new town names is highly not recommended currently. Why don't you make a NewGRF? And plus, you should not modify each language files. It should be done at Eints by each language's translators.

@nielsmh
Copy link
Contributor

nielsmh commented May 29, 2020

Make a NewGRF. New built-in town name generators are not accepted because they can not be versioned the same way a NewGRF town name set can be. Changes to the existing built-in town name generators can only be typographic in nature and they have a higher maintenance cost.

The BaNaNaS content service does not forbid having multiple "competing" entries that represent the same thing, even if there is already a Spanish town names set, you are free to upload a new, distinct one if you think you can do better.

@nielsmh nielsmh closed this May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants