validatePkgConfig: init #87866
Merged
validatePkgConfig: init #87866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldk
force-pushed
the
validate-pkgconfig-hook
branch
from
99515a0
to
7b5f8f4
Compare
|
Seems like this PR sunk down the list ;). Any comments @bhipple ? |
Ericson2314
reviewed
May 31, 2020
This adds the `validatePkgConfig` hook, which can be used to validate pkg-config files in the output(s). Currently, this will just run `pkg-config --validate` on all `.pc` files, capturing errors such as the issue that was fixed in NixOS#87789. The hook could be extended in the future with more fine-grained checks.
danieldk
force-pushed
the
validate-pkgconfig-hook
branch
from
7b5f8f4
to
127cdd0
Compare
Ericson2314
approved these changes
May 31, 2020
bhipple
approved these changes
Jun 3, 2020
|
Result of 6 packages built:- clmagma - mkl - python27Packages.mkl-service - python37Packages.mkl-service - python38Packages.mkl-service - validatePkgConfig |
bhipple
approved these changes
Jun 3, 2020
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This adds the
validatePkgConfighook, which can be used to validatepkg-config files in the output(s). Currently, this will just run
pkg-config --validateon all.pcfiles, capturing errors such asthe issue that was fixed in #87789.
The hook could be extended in the future with more fine-grained
checks.
I have also added a commit which enables this hook for the MKL derivation as an example.
This is the first time I touched the hooks at all, so I hope I didn't do anything bad ;).
@bhipple
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)