Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note for necessary step of setting password #87863

Closed
wants to merge 1 commit into from
Closed

Add note for necessary step of setting password #87863

wants to merge 1 commit into from

Conversation

FranklinYu
Copy link

Motivation for this change

#39915 (comment)

Things done

I don’t think they applies since this is only documentation update.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented May 28, 2020

I would rephrase the note to mention mutableUsers = false, and users.users.passwordFile, which is probably more frequent use-case than an unattended installation.

Also sudo nixos-enter --command passwd seems friendlier than chpasswd.

@FranklinYu
Copy link
Author

@rnhmjoj Sorry, I’m not sure how these two options are related to this note here. This note is only about the step of running

# nixos-install

as well as steps after that. IMO the two configuration options you mention should be specified in the step above it, namely

You should then edit /mnt/etc/nixos/configuration.nix to suit your needs:

# nano /mnt/etc/nixos/configuration.nix

As for the recommendation of nixos-enter, I don’t see why we would prefer it over simply not using --no-root-passwd, since both are intended for the same scenario (interactive installation).

I’m not yet familiar with NixOS so please don’t hesitate to correct my mistakes above.

@SuperSandro2000 SuperSandro2000 marked this pull request as draft November 28, 2020 05:05
@stale
Copy link

stale bot commented Jun 16, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 16, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 12, 2023
Janik-Haag
Janik-Haag reviewed Jun 19, 2023
View reviewed changes
Copy link
Member

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What keeps this from getting merged?

@Janik-Haag
Copy link
Member

I'll close this for now since no one answered. feel free to reopen anytime you have time to work on it again.

@Janik-Haag Janik-Haag closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Janik-Haag Janik-Haag Janik-Haag left review comments

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: nixos 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FranklinYu @rnhmjoj @Janik-Haag @doronbehar