Fixed build error with ${version} (forgot to escape those sequences, bash interpeted it and it didn't get in the commit comment)

Checks should be fixed when merging my addition to the maintainers list : #87938

Does ofborg checkout the tip of the PR or the merge tho? If it's the former you're going to have to merge it here regardless.

My english is a little bit rusted, are you asking me to merge the maintainers-list.nix modifications here? If so then I probably should close this now #87938.

No worries.

Yes, that should help OfBorg.

Yes go ahead and close it.

Patches have been merged upstream https://github.com/magiruuvelvet/OTPGen/

Cool. Then you can use fetchpatch with https://github.com/magiruuvelvet/OTPGen/commit/119dc46f1571c377c7eaf2d167deb142f6dcc9d6.patch and https://github.com/magiruuvelvet/OTPGen/commit/afd3fc87c4422bdf4f3978d4a2de1565a1d93283.patch instead of having the patches in-tree.

At this point, the package looks quite good but I am quite concerned about the number of bundled dependencies: https://github.com/magiruuvelvet/OTPGen/tree/master/Libs

For the bundled libs, an issue has been opened, I'll try to fix it myself if nothing is done.

Issue is here

Cool. Then you can use fetchpatch with https://github.com/magiruuvelvet/OTPGen/commit/119dc46f1571c377c7eaf2d167deb142f6dcc9d6.patch and https://github.com/magiruuvelvet/OTPGen/commit/afd3fc87c4422bdf4f3978d4a2de1565a1d93283.patch instead of having the patches in-tree.

I already suggested that on the initial version of the PR. Me reviews somehow got lost with all the updates..

ah, here it was: 9c7dcca#r426058136 :D

I already fixed it a few commits ago f70af1e

I failed moving to system cereal library. The author pointed out that some libs were modified so maybe this is the reason. He also pointed out that the boost stuff could be moved to c++17 goodies.
There also are libs that aren't yet in nixpkgs such as https://github.com/glassechidna/zxing-cpp/.
For those, I'll see what I can do to package them.

Started a new PR for zxing-cpp dependency here #88065

Testing this snippet to default.nix :

 preConfigurePhases = [ "prePatch" ];

  prePatch = ''
    rm -rf Libs/zlib
  '';

I get no error building, seems like cmake successfully found system's zlib :

-- Found ZLIB: /nix/store/kf2sh7c2fmizvycqq02aad1rfp6xswgv-zlib-1.2.11/lib/libz.so (found version "1.2.11")

This should confirm that we can successfully remove the bundled zlib. I'm just not sure if the prePatch thing is the way to go.

The zxing-cpp lib is not really suitable for being added to nixpkgs as explained here #88065 (comment). So our best choice is to keep the bundled zxing-cpp for the moment.

prePatch is fine.

Regarding the zxing-cpp, a compromise would be to introduce it to nixpkgs but not to all-packages.nix, only put it to the otpgen directory. Example:

Of course, it would be best if the project did not use unmaintained libraries. I would suggest https://github.com/mchehab/zbar as an alternative that is maintained and has a Qt widget.

Also there is no need to open new pull request when the packages are only needed for optgen (unless the changes are super big or something). We can just review it here.

Could you share the error message from the cereal library?

Here is the error logs : https://gist.github.com/SCOTT-HAMILTON/bd5015b9bef7a9738b830d2651057169

I have also managed to replace boost with std::filesystem but the patches aren't compatible with latest commit. So either I patch the v0.9.3 tag's commit or I put the patch in nixpkgs repo alongside default.nix. And of course I'll make a new patch to fit upstream HEAD.

Yeah, in that case, it will have to be in the nixpkgs repo. (Unless the project decides to create a 0.9 maintenance branch against which the 0.9.3 patches could be filed.)

So magiruuvelvet (OTPGen's author) is planning on rewriting it for a fresh new 2.0, no more modified libs, less dependencies, zbar instead of the unsupported zxing-cpp and other things. You can follow the proposal here magiruuvelvet/OTPGen#7.
For me, I'm done trying to convert HEADs commit patches to older v0.9.3 compatible patches. I will wait for the 2.0 to come (and will help if needed). So this thread is in hibernation (if such a thing exists) until the software is ready.