treewide: fix broken AlpineLinux repo links #87892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aver1y
changed the title
Aver1y
force-pushed
the
apparmor-fix-broken-patch-links
branch
from
61e29f5
to
e851445
Compare
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 0
and removed
2.status: merge conflict
labels
|
Seems like a general problem: $ ag 'https://git.alpinelinux.org/cgit/aports' -l
pkgs/tools/networking/vde2/default.nix
pkgs/tools/misc/figlet/default.nix
pkgs/servers/monitoring/net-snmp/default.nix
pkgs/applications/misc/xterm/default.nix
pkgs/os-specific/linux/powertop/default.nix
pkgs/os-specific/linux/pam/default.nix
pkgs/os-specific/linux/lvm2/default.nix
pkgs/os-specific/linux/apparmor/default.nix
pkgs/os-specific/linux/musl/default.nix
pkgs/development/libraries/gamin/default.nix
pkgs/development/libraries/libexecinfo/default.nix
pkgs/shells/tcsh/default.nix |
|
For some reason only some (a minority actually) of those links are broken. However the version without the |
|
Just fix them all. |
Actually not all of these were broken, however the version without the cgit part works for all links.
Aver1y
force-pushed
the
apparmor-fix-broken-patch-links
branch
from
e851445
to
71924bc
Compare
Aver1y
changed the title
Mic92
changed the title
Mic92
approved these changes
May 15, 2020
Mic92
pushed a commit
that referenced
this pull request
May 15, 2020
(cherry picked from commit 7517299)
|
Backport: [detached HEAD a8650ff] treewide: fix broken AlpineLinux repo links (#87892) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Apparently they changed their url scheme causing some of these links to break. E.g:
For some reason the versions with the
cgitpart still work for some of the links, however this just changes all of them.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)