Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gobject-introspection: clean-ups & build docs #87904

Merged
merged 5 commits into from May 23, 2020
Merged

gobject-introspection: clean-ups & build docs #87904

merged 5 commits into from May 23, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented May 15, 2020 •
edited by Ericson2314

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
gobject-introspection: clean up the expression
1bc7b68 
* format with nixpkgs-fmt
* reorder the attributes
* use pkg-config instead of the pkgconfig alias
* optional → optionals
* remove top-level `with lib;`
@jtojnar
gobject-introspection: more clean-ups
fbb86b1 
* remove glibcLocales now that glibc contains C.UTF-8
* remove libintl, that should be in by default or something
* update homepage
* add gnome team to maintainers
* remove the temporary libregress closer its creation
@jtojnar
gobject-introspection: consolidate patches
e4a009a 
and add comments
@jtojnar
gobject-introspection: add docs
fd5ea9d
@jtojnar
Copy link
Contributor Author

jtojnar commented May 17, 2020

@GrahamcOfBorg build gobject-introspection

1 similar comment
@jtojnar
Copy link
Contributor Author

jtojnar commented May 17, 2020

@GrahamcOfBorg build gobject-introspection

Mic92
Mic92 reviewed May 18, 2020
View reviewed changes
pkgs/development/libraries/gobject-introspection/default.nix
];

buildInputs = [
flex
bison
python3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @FRidh from a cross-compiling perspective we usually used the build-native python interpreter to build python packages, no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the build-native one is used in buildPythonPackage.

Copy link
Member

@FRidh FRidh May 20, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe they link against the interpreter, that is, use the C API?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build scripts need build python and some gobject utils are written in python so they need host python.

Mic92
Mic92 reviewed May 18, 2020
View reviewed changes
pkgs/development/libraries/gobject-introspection/default.nix
docbook_xml_dtd_45
python3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. It's in both. That would be fine I suppose.

@jtojnar jtojnar mentioned this pull request May 20, 2020
Closed
10 tasks
@jtojnar
Copy link
Contributor Author

jtojnar commented May 20, 2020

@GrahamcOfBorg build gobject-introspection

@Ericson2314
Copy link
Member

liblibarchive builds now

@jtojnar
Copy link
Contributor Author

jtojnar commented May 21, 2020 •
edited

@GrahamcOfBorg eval

1 similar comment
@jtojnar
Copy link
Contributor Author

jtojnar commented May 21, 2020

@GrahamcOfBorg eval

@Ericson2314
Copy link
Member

I just built x86_64 linux and darwin.

@Ericson2314 Ericson2314 merged commit 5aad832 into NixOS:staging May 23, 2020
@jtojnar jtojnar deleted the gi-docs branch May 23, 2020 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@FRidh FRidh FRidh left review comments

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@hedning hedning Awaiting requested review from hedning

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtojnar @Ericson2314 @Mic92 @FRidh