Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: c88290789c06
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 32b8ed738096
Choose a head ref
  • 3 commits
  • 1 file changed
  • 1 contributor

Commits on May 13, 2020

  1. chrome-gnome-shell: clean up

    * format with nixpkgs-fmt
    * reorder attributes
    * inline version
    jtojnar committed May 13, 2020
    Copy the full SHA
    c8683da View commit details
    Browse the repository at this point in the history
  2. chrome-gnome-shell: Fix missing introspection data

    It was crashing with:
    
        TypeError: gobject `__main__+ChromeGNOMEShell' doesn't support property `application_id'
    
    – that is the constructor of parent class Gio.Application does not recognize the kwarg.
    
    This is typically caused by missing pygobject overrides but I think ones for Gio are built-in into pygobject.
    
    Even weirder, adding just `${gobject-introspection}/lib/girepository-1.0` seems to fix the issue so it might be missing the whole typelib.
    But then why does not it fail when importing it?
    
    	from gi.repository import GLib, Gio
    
    For now, I am adding the Gio typelib which should been done from the start but more debugging should be done since weirdness like this can bring more bugs.
    
    Fixes: #87740
    jtojnar committed May 13, 2020
    Copy the full SHA
    5df7471 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2020

  1. Copy the full SHA
    32b8ed7 View commit details
    Browse the repository at this point in the history