Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wireshark: compile with QT_NO_DEBUG to avoid depending on qt*-dev #90277

Merged
merged 1 commit into from Jun 17, 2020
Merged

wireshark: compile with QT_NO_DEBUG to avoid depending on qt*-dev #90277

merged 1 commit into from Jun 17, 2020

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Jun 14, 2020

Motivation for this change

Before:

$ nix path-info -Sh /nix/store/arcw7029w14lrv9l8mpqib3sncza3nah-wireshark-qt-3.2.4
/nix/store/arcw7029w14lrv9l8mpqib3sncza3nah-wireshark-qt-3.2.4	   1.1G

After:

$ nix path-info -Sh /nix/store/c86nls44m73rcz5lq3jf4l2hr5sj9l10-wireshark-qt-3.2.4
/nix/store/c86nls44m73rcz5lq3jf4l2hr5sj9l10-wireshark-qt-3.2.4	 463.1M

Note that qt5's mkDerivation does the same thing automatically. However, wireshark is built as both a Qt and a non-Qt package in nixpkgs right now (wireshark-cli) and I couldn't find an easy way to refactor and use libsForQt5.callPackage. So instead I just cherry-picked the QT_NO_DEBUG part.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from fpletz and bjornfor June 14, 2020 03:09
@teto
Copy link
Member

teto commented Jun 17, 2020

now that's an impressive reduction :)

@teto teto merged commit 7198d97 into NixOS:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delroth @teto @bjornfor