Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/release-notes: Amend note about image compression #90391

Merged
merged 1 commit into from Jun 15, 2020
Merged

nixos/release-notes: Amend note about image compression #90391

merged 1 commit into from Jun 15, 2020

Conversation

samueldr
Copy link
Member

Things done

#90261

cc @prusnak

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@samueldr
Copy link
Member Author

I was unsure whether to state that the iso images are not compressed by default.

@prusnak
Copy link
Member

prusnak commented Jun 15, 2020 •
edited

I was unsure whether to state that the iso images are not compressed by default.

I think it would be a good idea. Maybe this would work?

<para>SD images are now compressed by default using <literal>zstd</literal>. The compression for ISO images has also been changed to <literal>zstd</literal>, but ISO images are still not compressed by default.</para>

@samueldr samueldr merged commit 04161c4 into NixOS:master Jun 15, 2020
@samueldr samueldr deleted the fix/manual-zstd-note branch June 15, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samueldr @prusnak