Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mono: don't propagate a dependency to glib-dev (15% closure size saving) #90288

Merged
merged 4 commits into from Jun 17, 2020
Merged

mono: don't propagate a dependency to glib-dev (15% closure size saving) #90288

merged 4 commits into from Jun 17, 2020

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Jun 14, 2020 •
edited

Motivation for this change

This was added in 2005 back in 51ce4ea. This was not commented or
explained anywhere, and it does not seem to be necessary anymore
according to some quick testing I did.

Reduces mono closure size by ~80M.

Before: /nix/store/4i8r0k2lq5602v1yqcr83vl9shamxnah-mono-5.20.1.27 516.8M
After: /nix/store/pckw8yafi1hpgs0djxak04zjq7fcww9l-mono-5.20.1.27 436.6M

Testing done: ran pinta and keepass. Both still seem to work as expected. Also did a round of nixpkgs-review and didn't notice any new regressions, but it's hard to tell since half of the stuff that depends on mono is broken...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from obadz, vrthra and thoughtpolice June 14, 2020 08:26
@delroth
Copy link
Contributor Author

delroth commented Jun 14, 2020

Related bug: #69146

@ofborg ofborg bot requested review from layus and taktoa June 14, 2020 10:48
@delroth
mono: don't propagate a dependency to glib-dev
f968422 
This was added in 2005 back in r51ce4ea2. This was not commented or
explained anywhere, and it does not seem to be necessary anymore
according to some quick testing I did.

Reduces mono closure size by ~100M.
@delroth
gio-sharp: add missing glib dependency
0cb5116
@delroth
dotnetPackages.FSharpAutoComplete: add missing glib dependency
8dd26c6
@delroth
pythonPackages.pythonnet: add missing glib dependency
fb3caa9
@ofborg ofborg bot requested a review from jraygauthier June 14, 2020 11:04
@taktoa taktoa removed their request for review June 14, 2020 17:36
layus
layus approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@layus layus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. Looks good to me.

@obadz obadz merged commit 0280b5e into NixOS:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layus layus layus approved these changes

@obadz obadz Awaiting requested review from obadz

@vrthra vrthra Awaiting requested review from vrthra

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@jraygauthier jraygauthier Awaiting requested review from jraygauthier

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delroth @layus @obadz