Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lmdb: 0.9.24 -> 0.9.25 #90247

Merged
merged 1 commit into from Jun 17, 2020
Merged

lmdb: 0.9.24 -> 0.9.25 #90247

merged 1 commit into from Jun 17, 2020

Conversation

yesbox
Copy link
Contributor

@yesbox yesbox commented Jun 13, 2020 •
edited

Change to official repo (according to https://www.openldap.org/software/repo.html) and the latest version. The Github read-only mirror is abandoned and has been outdated for months.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yesbox
lmdb: 0.9.24 -> 0.9.25
021570a 
Change to official repo. The Github read-only mirror is abandoned.
@yesbox yesbox requested review from jb55 and vcunat June 13, 2020 18:19
@vcunat
Copy link
Member

vcunat commented Jun 13, 2020

Changes look quite minimal and safe, but I'd prefer to do also a bit testing anyway before merging this.

@vcunat
Copy link
Member

vcunat commented Jun 17, 2020

Let's check darwin build as well.
@GrahamcOfBorg build lmdb

vcunat
vcunat approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems good. Others had a couple days to react, too.

@vcunat vcunat merged commit 52375b2 into NixOS:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@jb55 jb55 Awaiting requested review from jb55

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yesbox @vcunat