Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqldiff: init at 3.31.1 #90299

Closed
wants to merge 1 commit into from
Closed

sqldiff: init at 3.31.1 #90299

wants to merge 1 commit into from

Conversation

markus1189
Copy link
Contributor

@markus1189 markus1189 commented Jun 14, 2020

Motivation for this change

Add the sqldiff utility (https://sqlite.org/sqldiff.html)

NOTE: I also extracted the version.nix to share it across sql-analyzer, sqlite and sqldiff and removed the manual assert

I'm a bit unsure about the building process, we could also build sqldiff together with sqlite, but for that we would have to use a different source than the one that is currently used... I saw that the sql-analyzer does it in the way that I used for sqldiff

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markus1189
Copy link
Contributor Author

closing due to inactivity

@markus1189 markus1189 closed this Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants