Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[haskellUpdates] Unblock stack for stackage lts-16.0 #90263

Merged
merged 3 commits into from Jun 15, 2020

Conversation

dbaynard
Copy link
Contributor

@dbaynard dbaynard commented Jun 13, 2020

Motivation for this change

Unblocking #90032 — both cabal-install and stack build

(No nixos/tests seemed relevant)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dbaynard dbaynard changed the title Haskell updates [haskellUpdates] Unblock stack for stackage lts-16.0 Jun 13, 2020
The test suite hangs — issue haskell-tls/hs-certificate#120.

Required to build tls, and thereby stack.
The ‘Extended Master Secret (resumption)’ test is failing.
See vincenth/hs-tls#434.

Required for stack.
@dbaynard dbaynard marked this pull request as ready for review June 14, 2020 14:03
Comment on lines 1487 to 1489
# Stack
x509-validation = dontCheck super.x509-validation;
tls = dontCheck super.tls;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbaynard Thanks for taking the time to figure this out! I know it can be tough working with nix.

Could you add a more descriptive error message here, so that the next time someone is looking through this they can hopefully figure out why these two things have been marked dontCheck? Is it because the tests for x509-validation and tls try to access the network?

Once you update this comment I will merge this PR in.

Copy link
Contributor Author

@dbaynard dbaynard Jun 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't work out why the tests were hanging/failing, so I opened upstream issues.

@cdepillabout
Copy link
Member

Thanks for linking to the upstream issues in the code:

haskell-tls/hs-certificate#120
haskell-tls/hs-tls#434

LGTM, so merging in.

@cdepillabout cdepillabout merged commit e354ac9 into NixOS:haskell-updates Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants