neuralcoref: init at 4.0 #90252
neuralcoref: init at 4.0 #90252
Conversation
|
when updating a branch, please use rebase. E.g. |
| description = "Neuralcoref: Coreference Resolution in spaCy with Neural Networks"; | ||
| homepage = "https://github.com/huggingface/neuralcoref"; | ||
| license = licenses.mit; | ||
| maintainers = with maintainers; [ conradmearns ]; |
There was a problem hiding this comment.
Please create a separate commit that adds you to maintainers.nix. Look at 261912e as an example
maintainers: add <name>
| @@ -7426,6 +7426,8 @@ in { | |||
|
|
|||
| rxv = callPackage ../development/python-modules/rxv { }; | |||
|
|
|||
| neuralcoref = callPackage ../development/python-modules/neuralcoref {}; | |||
There was a problem hiding this comment.
please attempt to sort this
| doCheck = false; | ||
| # checkPhase = '' | ||
| # ${python.interpreter} -m pytest spacy/tests --vectors --models --slow | ||
| # ''; |
There was a problem hiding this comment.
There are no tests included. Please try to checkout from source and check if they have unit tests, and try to run them. Unit tests give a good indication that they package has a high degree of validity and correctness given the python package set.
If tests are not available, then please use pythonImportsCheck to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors.
|
@jonringer, sorry for the mess and late reply, I only partially know what I am doing. It may take me a while to be ready to create tests for this, in the meantime I will add the maintainer entry via a separate package PR Should I and revert or change the git history to rebase? I'm assuming I would need to do this anyway to fix the mess with the maintainer entry, but I don't know how to do this yet. |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
|
@ConradMearns Are you still interested in pursuing this? I see you subsequently submitted and maintain the obsidian package, so maybe the places where this gummed up are more tractable now? |
|
Tentatively closing. Happy to reopen if you want to pursue it. |
Motivation for this change
Add the neuralcoref module to python3Packages
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)I have not yet "Tested execution of all binary files" by running the module in Python yet. Been overloaded at work 🙃
Let me know if there's anything I can improve or should change, thanks!