New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
printrun: 1.6.0 -> 2.0.0rc5 #90272
printrun: 1.6.0 -> 2.0.0rc5 #90272
Conversation
python27Packages.buildPythonApplication rec { | ||
name = "printrun-20150310"; | ||
python36Packages.buildPythonApplication rec { | ||
name = "printrun"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name = "printrun"; | |
pname = "printrun"; | |
version = "2.0.0rc5"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/kliment/Printrun/releases
The 2.0.0rc5 release is over 2 years old which is why I pointed to a recent commit instead.
2.0.0rc6 was released just 20 days ago but it includes kliment/Printrun@f16b24d which breaks the build:
Executing pipInstallPhase
/build/Printrun-2.0.0rc6/dist /build/Printrun-2.0.0rc6
Processing ./Printrun-2.0.0rc6-cp36-cp36m-linux_x86_64.whl
ERROR: Could not find a version that satisfies the requirement dbus-python>=1.2.0; sys_platform == "linux" (from Printrun==2.0.0rc6) (from versions: none)
ERROR: No matching distribution found for dbus-python>=1.2.0; sys_platform == "linux" (from Printrun==2.0.0rc6)
builder for '/nix/store/vz56hcsmbs4jfic9ccldlaxvbklxprn0-Printrun-2.0.0rc6.drv' failed with exit code 1
error: build of '/nix/store/vz56hcsmbs4jfic9ccldlaxvbklxprn0-Printrun-2.0.0rc6.drv' failed
Not sure what's going on, maybe it needs dbus-python as a wheel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try adding dbus-python to propagatedBuildInputs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it there already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, indeed. Weird. can you bump the version anyway so I can try it localy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message of the offending commit seems relevant:
This makes it possible to build sdists and wheels on Linux at least. Unfortunately dbus-python and wxPython have no Linux wheels, but otherwise the wheel is pip installable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebased against master I get the following error during build, which got be fixable?
builder for '/nix/store/w31k4nic20w6blb26236fdppswvfyij4-Printrun-2.0.0rc6.drv' failed with exit code 1; last 10 log lines:
Finished executing setuptoolsBuildPhase
installing
Executing pipInstallPhase
/build/Printrun-2.0.0rc6/dist /build/Printrun-2.0.0rc6
Processing ./Printrun-2.0.0rc6-cp36-cp36m-linux_x86_64.whl
Requirement already satisfied: numpy>=1.8.2 in /nix/store/lh7ffdflm8zsp3l9pncpcd35nq6krx78-python3.6-numpy-1.19.1/lib/python3.6/site-packages (from Printrun==2.0.0rc6) (1.19.1)
Requirement already satisfied: psutil>=2.1 in /nix/store/ahz7qz4w759ji6a2zhwx0g4hm99lzg06-python3.6-psutil-5.7.2/lib/python3.6/site-packages (from Printrun==2.0.0rc6) (5.7.2)
ERROR: Could not find a version that satisfies the requirement cairocffi (from Printrun==2.0.0rc6) (from versions: none)
ERROR: No matching distribution found for cairocffi (from Printrun==2.0.0rc6)
builder for '/nix/store/w31k4nic20w6blb26236fdppswvfyij4-Printrun-2.0.0rc6.drv' failed with exit code 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sadly afterwards I get the dbus-python error again :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not merge master into PRs.
Result of 1 package failed to build:
Finished executing setuptoolsBuildPhase |
69d2734
to
1e71d21
Compare
2.0.0rc7 is now out but it has the same dbus-python error as 2.0.0rc6 so I'm pointing this PR back to 2.0.0rc5 which I managed to build. |
@alexfmpe please fix the merge conflict. |
1e71d21
to
4002133
Compare
@SuperSandro2000 Fixed |
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)