Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

printrun: 1.6.0 -> 2.0.0rc5 #90272

Merged
merged 1 commit into from Jan 13, 2021
Merged

Conversation

alexfmpe
Copy link
Member

@alexfmpe alexfmpe commented Jun 14, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

python27Packages.buildPythonApplication rec {
name = "printrun-20150310";
python36Packages.buildPythonApplication rec {
name = "printrun";
Copy link
Member

@Lassulus Lassulus Aug 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "printrun";
pname = "printrun";
version = "2.0.0rc5";

Copy link
Member Author

@alexfmpe alexfmpe Aug 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kliment/Printrun/releases
The 2.0.0rc5 release is over 2 years old which is why I pointed to a recent commit instead.

2.0.0rc6 was released just 20 days ago but it includes kliment/Printrun@f16b24d which breaks the build:

Executing pipInstallPhase
/build/Printrun-2.0.0rc6/dist /build/Printrun-2.0.0rc6
Processing ./Printrun-2.0.0rc6-cp36-cp36m-linux_x86_64.whl
ERROR: Could not find a version that satisfies the requirement dbus-python>=1.2.0; sys_platform == "linux" (from Printrun==2.0.0rc6) (from versions: none)
ERROR: No matching distribution found for dbus-python>=1.2.0; sys_platform == "linux" (from Printrun==2.0.0rc6)
builder for '/nix/store/vz56hcsmbs4jfic9ccldlaxvbklxprn0-Printrun-2.0.0rc6.drv' failed with exit code 1
error: build of '/nix/store/vz56hcsmbs4jfic9ccldlaxvbklxprn0-Printrun-2.0.0rc6.drv' failed

Not sure what's going on, maybe it needs dbus-python as a wheel?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try adding dbus-python to propagatedBuildInputs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it there already?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, indeed. Weird. can you bump the version anyway so I can try it localy?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message of the offending commit seems relevant:

This makes it possible to build sdists and wheels on Linux at least. Unfortunately dbus-python and wxPython have no Linux wheels, but otherwise the wheel is pip installable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebased against master I get the following error during build, which got be fixable?

builder for '/nix/store/w31k4nic20w6blb26236fdppswvfyij4-Printrun-2.0.0rc6.drv' failed with exit code 1; last 10 log lines:
  Finished executing setuptoolsBuildPhase
  installing
  Executing pipInstallPhase
  /build/Printrun-2.0.0rc6/dist /build/Printrun-2.0.0rc6
  Processing ./Printrun-2.0.0rc6-cp36-cp36m-linux_x86_64.whl
  Requirement already satisfied: numpy>=1.8.2 in /nix/store/lh7ffdflm8zsp3l9pncpcd35nq6krx78-python3.6-numpy-1.19.1/lib/python3.6/site-packages (from Printrun==2.0.0rc6) (1.19.1)
  Requirement already satisfied: psutil>=2.1 in /nix/store/ahz7qz4w759ji6a2zhwx0g4hm99lzg06-python3.6-psutil-5.7.2/lib/python3.6/site-packages (from Printrun==2.0.0rc6) (5.7.2)
  ERROR: Could not find a version that satisfies the requirement cairocffi (from Printrun==2.0.0rc6) (from versions: none)
  ERROR: No matching distribution found for cairocffi (from Printrun==2.0.0rc6)
  builder for '/nix/store/w31k4nic20w6blb26236fdppswvfyij4-Printrun-2.0.0rc6.drv' failed with exit code 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sadly afterwards I get the dbus-python error again :/

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge master into PRs.

pkgs/applications/misc/printrun/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/printrun/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/printrun/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 90272 run on x86_64-linux 1

1 package failed to build:
  • printrun

Finished executing setuptoolsBuildPhase
installing
Executing pipInstallPhase
/build/Printrun-2.0.0rc6/dist /build/Printrun-2.0.0rc6
Processing ./Printrun-2.0.0rc6-cp36-cp36m-linux_x86_64.whl
Requirement already satisfied: appdirs>=1.4.0 in /nix/store/svy5cp8xbbszaqc5hxm7hm4fkqcmj64z-python3.6-appdirs-1.4.4/lib/python3.6/site-packages (from Printrun==2.0.0rc6) (1.4.4)
Requirement already satisfied: numpy>=1.8.2 in /nix/store/4j9h59l2716jvsfhrd0js51cp85q2pcx-python3.6-numpy-1.19.4/lib/python3.6/site-packages (from Printrun==2.0.0rc6) (1.19.4)
Requirement already satisfied: psutil>=2.1 in /nix/store/mbfdg4clj0j5brjd7yjp0kz79913qfwy-python3.6-psutil-5.7.3/lib/python3.6/site-packages (from Printrun==2.0.0rc6) (5.7.3)
ERROR: Could not find a version that satisfies the requirement cairocffi (from printrun)
ERROR: No matching distribution found for cairocffi
cannot build derivation '/nix/store/wjyyvqxkhn3718sg2z2zgf0imdcxsp0z-env.drv': 1 dependencies couldn't be built

@alexfmpe
Copy link
Member Author

2.0.0rc7 is now out but it has the same dbus-python error as 2.0.0rc6 so I'm pointing this PR back to 2.0.0rc5 which I managed to build.
Redid on top of current master and force pushed to remove intermediate broken state and the merge commit

@SuperSandro2000
Copy link
Member

@alexfmpe please fix the merge conflict.

@alexfmpe
Copy link
Member Author

@SuperSandro2000 Fixed

@alexfmpe alexfmpe changed the title printrun: 20150310 -> 2.0.0rc5 printrun: 1.6.0 -> 2.0.0rc5 Jan 13, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 90272 run on x86_64-linux 1

1 package built:
  • printrun

@SuperSandro2000 SuperSandro2000 merged commit 0499c16 into NixOS:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants