Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boot.initrd.luks.devices: add preOpenCommands and postOpenCommands #90307

Merged
merged 1 commit into from Jul 8, 2020

Conversation

eyJhb
Copy link
Member

@eyJhb eyJhb commented Jun 14, 2020

Motivation for this change

Until we get systemd for stage-1, there are some obstacles for various filesystem things.
My usecase is, that I have a ZFS encrypted pool/drive, and a LUKS encrypted drive.
The key to the LUKS encrypted drive is in a dataset in my ZFS pool, so I need to mount that before I can get the key to unlock, which this fixes.

Things done

Simple to see in the diff.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace merged commit dfe59e0 into NixOS:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants