Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fast-downward: 2019-05-13 -> 19.12, build on darwin, fix runtime issues #90281

Merged
merged 2 commits into from Aug 17, 2020
Merged

fast-downward: 2019-05-13 -> 19.12, build on darwin, fix runtime issues #90281

merged 2 commits into from Aug 17, 2020

Conversation

purcell
Copy link
Member

@purcell purcell commented Jun 14, 2020 •
edited

Motivation for this change

This package also builds happily on Darwin.

Update:

  • Fixed issue where fast-downward program in existing derivation failed on both platforms due to not finding the release directory. Freezing the libexec subdir as the default release dir in arguments.py resolves this.
  • Updated to latest stable release
  • Use upstream's standard "build.py" configuration mechanism instead of working around it.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels Jun 14, 2020
@ofborg ofborg bot requested a review from abbradar June 14, 2020 08:06
@purcell
Copy link
Member Author

purcell commented Jun 14, 2020

Hmm, bear with me, testing this a little more first.

@purcell
Copy link
Member Author

purcell commented Jun 14, 2020

The existing package is broken even on Linux, in fact:

nix run -f '<nixpkgs>'  fast-downward -c fast-downward domain.pddl problem-1.pddl --search "astar(add())"                                                                         /tmp
INFO     Running translator.
Could not find build 'release' at /nix/store/d0xizg2aqqar6g1ls9mjmzj38z67r422-fast-downward-2019-05-13/lib/python3.7/site-packages/builds/release/bin. Please run './build.py release'.

I'm having a quick look at fixing this.

@purcell
fastdownward: 2019-05-13 -> 19.12
af76ba6 
- Use supplied build.py mechanism instead of working around it
- Freeze release location into resulting Python so fast-downward script actually works
@purcell purcell changed the title fast-downward: also build on darwin fast-downward: 2019-05-13 -> 19.12, build on darwin, fix runtime issues Jun 14, 2020
@purcell
Copy link
Member Author

purcell commented Jun 14, 2020

Fixed now, updated and improved.

@purcell
Copy link
Member Author

purcell commented Jun 22, 2020

Also /cc @ocharles, who may well be using this.

@ocharles
Copy link
Contributor

I actually had no idea we had this in nixpkgs! At work we have our own derivation to build this.

@purcell
Copy link
Member Author

purcell commented Jun 22, 2020

I actually had no idea we had this in nixpkgs! At work we have our own derivation to build this.

I'm guessing your own derivation would put downward in $out/bin, since that's what you're calling directly from the Haskell wrapper. I believe in this one it ends up in libexec.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/204

@purcell
Copy link
Member Author

purcell commented Aug 16, 2020

Bump! Nobody seems to have strong feelings either way about this, so I might suggest we err on the side of merging this, since it fixes a concrete pre-existing issue.

@purcell
Copy link
Member Author

purcell commented Aug 17, 2020

cc @marsam: this is another PR that's a bit stuck.

@marsam marsam merged commit b05ede0 into NixOS:master Aug 17, 2020
@purcell
Copy link
Member Author

purcell commented Aug 17, 2020

Thanks!

@purcell purcell deleted the fast-downward-darwin branch August 17, 2020 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@purcell @ocharles @nixos-discourse @marsam