LGTM, but I did not test.

LGTM, but I did not test.

@wucke13 I ran it and walked through a small timing setup. No issues with that.

Can you mark the PR as reviewed then?

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/191

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/180

/marvin opt-in
/status needs_merger

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

The PR author cannot set the status to needs_merger.
Please wait for an external review.
If you are not the PR author and you are reading this, please review the usage of this bot.
You may be able to help.
Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

Why are the manual build steps necessary? The Arch AUR version of this package uses a version derived url from ST.
I've created my own version of the update using that url and everything seems to work fine.
2370ca0

My best guess is @wucke13 did it this way because when downloading this you have to accept a license agreement.
Some nix packages require a license agreement flag to be set - could we do the same here?

The license provided with the zip does generally permit redistribution, so ST is presumably fine with people not going though the license/auth flow. My guess would be @wucke13 wasn't aware the package could be downloaded without signing in and therefore made the process manual.

@justin-gerhardt Exactly, I wasn't aware. Would you like to make a PR with your changes? It sounds promising not having to download stuff manually.