steam: switch to correct runtime tarball #90286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my previous commit (593c28b) I used the wrong upstream artifact for the runtime. After reading the documentation in the ValveSoftware/steam-runtime repo, I now know that the steam-runtime tarball is what I actually wanted. I also used 'diff' to compare the various artifacts with the old runtime this package used before, and the steam-runtime one is certainly the closest. Most importantly, switching to the right steam-runtime package reportedly fixes issues for other users (fixes NixOS#90229). This also entirely removes the amd64/i386 split from runtime.nix because the upstream package bundles both together, and if that's how upstream wants to distribute this, it seems best to follow their lead.
tex
approved these changes
Jun 14, 2020
killercup
approved these changes
Jun 14, 2020
|
Great change, this makes stuff easier again. Thanks for finding this out 馃憤 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my previous PR (#87243) I used the wrong upstream artifact for
the runtime. After reading the documentation in the
ValveSoftware/steam-runtime repo, I now know that the steam-runtime
tarball is what I actually wanted.
I also used 'diff' to compare the various artifacts with the old runtime
this package used before, and the steam-runtime one is certainly the
closest.
Most importantly, switching to the right steam-runtime package
reportedly fixes issues for other users (fixes #90229).
This also entirely removes the amd64/i386 split from runtime.nix because
the upstream package bundles both together, and if that's how upstream
wants to distribute this, it seems best to follow their lead.
Motivation for this change
Fixes an issue reported in #90229
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cc @hrdinka since you helped with the last PR. Apologies for my mistake here 馃槄