Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins: update #90242

Merged
merged 1 commit into from Jun 13, 2020
Merged

Conversation

siriobalmelli
Copy link
Contributor

Signed-off-by: Sirio Balmelli sirio@b-ad.ch

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/90242
1 package failed to build:
vimPlugins.YouCompleteMe

53 packages built:
vimPlugins.Jenkinsfile-vim-syntax vimPlugins.ale vimPlugins.calendar-vim vimPlugins.coc-fzf vimPlugins.coc-go vimPlugins.coc-nvim vimPlugins.defx-nvim vimPlugins.denite-nvim vimPlugins.deoplete-fish vimPlugins.deoplete-khard vimPlugins.deoplete-lsp vimPlugins.deoplete-nvim vimPlugins.echodoc-vim vimPlugins.fzf-vim vimPlugins.gentoo-syntax vimPlugins.ghcid vimPlugins.goyo-vim vimPlugins.julia-vim vimPlugins.lf-vim vimPlugins.neco-ghc vimPlugins.neoformat vimPlugins.neosnippet-vim vimPlugins.nerdcommenter vimPlugins.nvim-lsp vimPlugins.onehalf vimPlugins.rust-vim vimPlugins.splitjoin-vim vimPlugins.tagbar vimPlugins.unicode-vim vimPlugins.verilog_systemverilog-vim vimPlugins.vim-airline vimPlugins.vim-anzu vimPlugins.vim-bazel vimPlugins.vim-codefmt vimPlugins.vim-devicons vimPlugins.vim-elm-syntax vimPlugins.vim-fireplace vimPlugins.vim-gitgutter vimPlugins.vim-go vimPlugins.vim-illuminate vimPlugins.vim-jsdoc vimPlugins.vim-ledger vimPlugins.vim-lsc vimPlugins.vim-maktaba vimPlugins.vim-plug vimPlugins.vim-polyglot vimPlugins.vim-signify vimPlugins.vim-spirv vimPlugins.vim-test vimPlugins.vim-visual-multi vimPlugins.vim-which-key vimPlugins.vimtex vimPlugins.vista-vim

@jonringer jonringer merged commit ca8e5a6 into NixOS:master Jun 13, 2020
@siriobalmelli siriobalmelli deleted the update/vimPlugins branch June 14, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants