Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add curl middleware plugin #3694

Closed
wants to merge 1 commit into from
Closed

Add curl middleware plugin #3694

wants to merge 1 commit into from

Conversation

Kloenk
Copy link
Member

@Kloenk Kloenk commented Jun 13, 2020 •
edited by Ericson2314

Motivation

This adds the possibility for plugins to alter the curl request.
This is intended for use on gitlab/github behind and ssl client certificate. But can also be used for tarballs or files behind an ssl client certificate or behind Basic auth.

Context

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or incompatible change: updated release notes

Priorities

Add 👍 to pull requests you find important.

@Kloenk
Copy link
Member Author

Kloenk commented Jul 1, 2020

CC @edolstra @imalsogreg

@Kloenk
add curl middleware plugin
aa3f6b0 
add a middleware plugin facility to change the curl request.
This is intendet to be use for own gitlab/github instances behind an ssl
client cert authentification.
@Kloenk Kloenk changed the base branch from flakes to master October 16, 2020 20:58
@Kloenk
Copy link
Member Author

Kloenk commented Oct 16, 2020

Also rebased and targeted master, as flakes is already merged

@Kloenk
Copy link
Member Author

Kloenk commented Apr 9, 2021

Ping @edolstra @Ericson2314

@stale
Copy link

stale bot commented Oct 11, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the stale label Oct 11, 2021
@Ericson2314 Ericson2314 added the feature Feature request or proposal label Mar 11, 2023
@stale stale bot removed the stale label Mar 11, 2023
@Ericson2314 Ericson2314 added the fetching Networking with the outside (non-Nix) world label Mar 11, 2023
@Ericson2314
Copy link
Member

Ericson2314 commented Mar 11, 2023 •
edited

@Kloenk Do you still want this? If so, could you write a plugin test for this?

Marked as draft because no tests yet.
Applied the (much more recent than this PR) pull request description template to it.

@Ericson2314 Ericson2314 marked this pull request as draft March 11, 2023 03:09
@Ericson2314 Ericson2314 changed the title add curl middleware plugin Add curl middleware plugin Mar 11, 2023
@Kloenk
Copy link
Member Author

Kloenk commented Mar 13, 2023

I currently don't have a direct use for it (but maybe in the future). I also don't really have time to implement it later. I would suggest closing, and when someone needs it, we can revisit it

@Ericson2314
Copy link
Member

OK thanks for replying @Kloenk. Will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 left review comments

@thufschmitt thufschmitt Awaiting requested review from thufschmitt thufschmitt will be requested when the pull request is marked ready for review thufschmitt is a code owner

Assignees
No one assigned
Labels
feature Feature request or proposal fetching Networking with the outside (non-Nix) world
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kloenk @Ericson2314