Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

marp-cli: init at 0.18.1 #90241

Closed
wants to merge 1 commit into from
Closed

marp-cli: init at 0.18.1 #90241

wants to merge 1 commit into from
+1,049 −910

Conversation

mgdm
Copy link
Contributor

@mgdm mgdm commented Jun 13, 2020

Motivation for this change

The existing marp tool is being deprecated, and marp-cli is a component of the replacement

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
@stale
Copy link

stale bot commented Apr 18, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 18, 2021
@dccsillag
Copy link

Is this a lost effort?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Feb 11, 2022
@mgdm
Copy link
Contributor Author

mgdm commented Feb 11, 2022

I’ll have a look at resolving the conflicts over the weekend

@dccsillag
Copy link

dccsillag commented Feb 11, 2022 •
edited
Loading

Oh, thank you very much!

(No need to rush it, though.)

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 12, 2022
@fufexan
Copy link
Contributor

fufexan commented Jan 4, 2023

What's the status on this?

@fufexan fufexan mentioned this pull request Jan 4, 2023
Closed
13 tasks
@GuillaumeDesforges
Copy link
Contributor

Closing in favor of #216443 (please reopen as needed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mgdm @dccsillag @fufexan @GuillaumeDesforges @ryantm