Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wiimms-iso-tools: init at 3.02a #90324

Merged
merged 1 commit into from Aug 22, 2020
Merged

wiimms-iso-tools: init at 3.02a #90324

merged 1 commit into from Aug 22, 2020

Conversation

nilp0inter
Copy link
Contributor

@nilp0inter nilp0inter commented Jun 14, 2020 •
edited

Motivation for this change

I'd like to use WIT to manage my Wii and GameCube backups from my NixOS box.

Things done

Packaged using mkDerivation. I had to patch the sources because is not using standard autotools configure and is trying to install to hard-coded paths.

I tested it under Linux only but it should build well under MacOs given that the author have binaries available for that platform in their website.

Please note that although the version seems to be marked as alpha, it is the latest stable version that has been available for more than a year.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nilp0inter nilp0inter marked this pull request as draft June 14, 2020 11:54
@nilp0inter nilp0inter marked this pull request as ready for review June 14, 2020 12:48
@marius851000
Copy link
Contributor

marius851000 commented Jun 16, 2020 •
edited

Reviewed points
  • package path fits guidelines (another possibility would be nixpkgs/pkgs/tools/archivers/)
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86-64
  • executables tested on x86-64 (nixos)
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • phases are respected
  • patches that are remotely available are fetched with fetchpatch
Possible improvements

add a value for meta.platforms for caching with hydra

Comments

tested extraction of a wii iso file with wit EXTRACT (source file) (dest dir)

@nilp0inter
Copy link
Contributor Author

@marius851000 , anything else that I can do to improve the pull request?

@marius851000
Copy link
Contributor

look good to me

@Lassulus Lassulus merged commit 9db2078 into NixOS:master Aug 22, 2020
@djanatyn djanatyn mentioned this pull request Nov 11, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marius851000 marius851000 marius851000 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nilp0inter @marius851000 @Lassulus