Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gosec: 1.2.0 -> 2.3.0 #90319

Merged
merged 1 commit into from Jun 28, 2020
Merged

gosec: 1.2.0 -> 2.3.0 #90319

merged 1 commit into from Jun 28, 2020

Conversation

nilp0inter
Copy link
Contributor

Motivation for this change

The available version of gosec in nixpkgs is very outdated and doesn't support checking go projects using go modules outside of the GOPATH.

Things done

Update gosec to latest version 2.3.0 and simplify by building with buildGoModule.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants