Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.flake8: 3.7.9 -> 3.8.3 #90256

Closed
wants to merge 1 commit into from
Closed

pythonPackages.flake8: 3.7.9 -> 3.8.3 #90256

wants to merge 1 commit into from

Conversation

kalekseev
Copy link
Contributor

Also updated deps that didn't much flake8 requirements

Motivation for this change

https://gitlab.com/pycqa/flake8/-/blob/master/docs/source/release-notes/3.8.3.rst

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kamadorueda June 13, 2020 20:40
@jonringer
Copy link
Contributor

since this change causes over 500 rebuilds, do you mind targeting the staging branch

git rebase --onto=staging HEAD~1
git push .. ... --force

then change the base branch in the github PR from master -> staging

See https://nixos.org/nixpkgs/manual/#submitting-changes-staging-branch for more details on staging branch

@jonringer
Copy link
Contributor

that being said, staging is at 3.8.2

@FRidh
Copy link
Member

FRidh commented Jun 14, 2020

and now staging is at 3.8.3 as well 8bbc4b0

@FRidh FRidh closed this Jun 14, 2020
@kalekseev
Copy link
Contributor Author

Somehow I completely missed staging part of nixpkgs, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@kamadorueda kamadorueda Awaiting requested review from kamadorueda

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kalekseev @jonringer @FRidh