nixos/corerad: use passAsFile while converting settings JSON to TOML #90380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Layher <mdlayher@gmail.com>
|
@GrahamcOfBorg test corerad |
cleverca22
approved these changes
Jun 14, 2020
|
I thought about this in the original PR, but didn't bother mentioning it :P (also since #75584 implements it correctly anyways, which would be used in the future). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matt Layher mdlayher@gmail.com
Motivation for this change
Handle a possible issue with single quoting in JSON by using
passAsFileto convert JSON to TOML using an intermediary file. Reported by "clever" in #nixos-on-your-router.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)/cc @infinisil due to reviewing the previous PR: #89781, and @cleverca22 (I assume you are clever from IRC, but if not, apologies!)