Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardware/u2f: remove module #90343

Merged
merged 1 commit into from Jun 15, 2020
Merged

hardware/u2f: remove module #90343

merged 1 commit into from Jun 15, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jun 14, 2020

udev gained native support to handle FIDO security tokens, so we don't
need a module which only added the now obsolete udev rules.

Fixes: #76482

Tested by both succesfully doing the U2F browser dance and using yubioauth-desktop, after having my system switched to it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @timstott @hkjn

udev gained native support to handle FIDO security tokens, so we don't
need a module which only added the now obsolete udev rules.

Fixes: NixOS#76482
@flokli flokli merged commit af3c100 into NixOS:master Jun 15, 2020
@flokli flokli deleted the hardware-u2f-remove branch June 15, 2020 15:53
isobit added a commit to isobit/nixos-profiles that referenced this pull request Jul 14, 2020
This option is no longer needed as udev gained native support to handle
FIDO security tokens, making the udev rules obsolete.

See:
NixOS/nixpkgs#76482
NixOS/nixpkgs#90343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Unknown group plugdev" errors from pkgs.libu2f-host
2 participants