Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.croniter: fix build #90357

Closed
wants to merge 1 commit into from
Closed

pythonPackages.croniter: fix build #90357

wants to merge 1 commit into from

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Jun 14, 2020

Has new dependencies after update:
https://github.com/taichino/croniter/blob/master/requirements/base.txt
https://github.com/taichino/croniter/blob/master/requirements/test.txt

CC @FRidh @jonringer

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple bhipple changed the title pythonPackages.croniter: fix build pythonPackages.croniter: fix build on staging-next Jun 14, 2020
@bhipple bhipple mentioned this pull request Jun 14, 2020
Merged
@bhipple
Copy link
Contributor Author

bhipple commented Jun 14, 2020

Result of nixpkgs-review pr 90357 1

2 packages marked as broken and skipped:
- python37Packages.privacyidea-ldap-proxy
- python38Packages.privacyidea-ldap-proxy
3 packages failed to build:
- apache-airflow (python37Packages.apache-airflow)
- python27Packages.croniter
- python27Packages.privacyidea
4 packages built:
- python37Packages.croniter
- python37Packages.privacyidea
- python38Packages.croniter
- python38Packages.privacyidea

@ofborg ofborg bot requested a review from costrouc June 14, 2020 15:02
@FRidh FRidh changed the base branch from staging-next to master June 15, 2020 06:27
@FRidh
Copy link
Member

FRidh commented Jun 15, 2020

@GrahamcOfBorg build pythonPackages.croniter python3Packages.croniter

@flokli
Copy link
Contributor

flokli commented Jun 18, 2020

Still fails to build, right?

@FRidh FRidh changed the title pythonPackages.croniter: fix build on staging-next pythonPackages.croniter: fix build Jun 19, 2020
@FRidh
Copy link
Member

FRidh commented Jun 19, 2020

python3.pkgs.chroniter builds on master and python2 version is disabled

@FRidh FRidh closed this Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @FRidh @flokli