Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thunderbird: Patch rpath to find libudev, which is part of systemd. #90275

Merged
merged 1 commit into from Jun 14, 2020

Conversation

IreneKnapp
Copy link
Contributor

Motivation for this change

This fixes #87642, allowing U2F to work during OAUTH2 authentication flows, which is necessary for Thunderbird to work with Google accounts which are set to require U2F as an authentication method. The fix works by ensuring that the systemd lib directory is in Thunderbird's rpath, thus allowing Thunderbird to locate libudev at runtime.

I first tried to do this by symlinking libudev, as several other packages do, but it didn't work and I don't know why. This approach does work, so it has that going for it, which is nice.

Given how subtle this issue is, it would be really nice to have an automated test for it, to prevent regressions. To write one, though, I would need to spin up a web server running some form of U2F code, and script the Thunderbird UI heavily. I'm not aware that there's any testing framework in nixpkgs for that sort of thing. So I'm not going to do that work, but if somebody with more experience writing testing harnesses in nixpkgs wants to take it on, I'd be happy to advise.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from nbp, edolstra and lovesegfault June 14, 2020 02:08
@samueldr samueldr requested a review from taku0 June 14, 2020 02:20
@IreneKnapp IreneKnapp changed the title Help Thunderbird find libudev, which is in the systemd lib dir. thunderbird: Patch rpath to find libudev, which is part of systemd. Jun 14, 2020
Copy link
Contributor

@taku0 taku0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note for future readers: Firefox set LD_LIBRARY_PATH in the wrapper. #42547

@samueldr samueldr merged commit 3b41eb1 into NixOS:master Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thunderbird U2F support doesn't work
3 participants