anki: more no-op exp cleanup #90368
anki: more no-op exp cleanup #90368
Conversation
| @@ -42,7 +42,7 @@ let | |||
| pname = "anki-manual"; | |||
| inherit version; | |||
| src = fetchFromGitHub { | |||
| owner = "dae"; | |||
| owner = "ankitects"; | |||
There was a problem hiding this comment.
That’s not a no-op holy f heck.
I do hope that slipped into this commit by mistake.
There was a problem hiding this comment.
This being said, it looks like ankisrs.net now points to the ankitects repo, so IMO this is not a problem (even though it doesn't match the commit name). (Also, the build will probably not be affected, as the reference and hash stay the same)
There was a problem hiding this comment.
https://github.com/dae/ankidocs is a URL redirect to https://github.com/ankitects/anki-docs now, so it is a no-op.
I can change the sha256 to garbage and nix will re-fetch and tell me the same hash. Am I missing something?
There was a problem hiding this comment.
Yeah, please put it in a different commit explaining that.
|
|
||
| postPatch = '' | ||
| # Remove unused starter. We'll create our own, minimalistic, | ||
| # starter. | ||
| # rm anki/anki |
There was a problem hiding this comment.
Is this not relevant anymore?
There was a problem hiding this comment.
It was commented out back in 2018 and we seem to have been fine without it, so I'd say so:
a30e304
The original repo has been transferred on github, so the URL is a redirect to here.
Continued progress towards #89745; just simplifying a bit.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)