New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.flake8: fix dependencies #90366
Conversation
@GrahamcOfBorg build python.pkgs.flake8 python3.pkgs.flake8 |
1 similar comment
@GrahamcOfBorg build python.pkgs.flake8 python3.pkgs.flake8 |
Looks like this should be cherry-picked to staging-next as well. |
not into staging-next because it would cause too big of a rebuild for no real gain |
@FRidh @Mic92 master is broken for me now because of this dependency
|
I cannot confirm this on d35735a:
|
It works on python3.8 because importlib_metadata is in stdlib, for python3.7 it's a separate library https://github.com/NixOS/nixpkgs/pull/90366/files#diff-9c09aa30a0ca61fd3e14aba395286af9R20 |
Just be patient, the change is in staging-next by now and will end up in master in a couple of days of nothing strange happens. |
That's not the problem for me I switched to python3.8 version, I just thought that broken version slipped into master by mistake
so am I right that we can ship a (partially) broken version to master from time to time if the fix requires big rebuilds or something else? |
Sometimes bugs end up in master, and fixing it requires a long rebuild. |
There's a reason why it's called unstable on the release channel. There's no gaurentee about breakages, both in APIs and builds. Package updates to core libraries often break downstream packages. That's just how software works currently. And it's not realistic to expect volunteer maintainers to fix builds for ~70k builds across 2 architectures and 2 platforms. |
Thanks for you replies, no complains here, just want to understands what policies are applied to different channels. |
Motivation for this change
https://gitlab.com/pycqa/flake8/-/blob/3.8.3/setup.cfg#L44-51
https://gitlab.com/pycqa/flake8/-/commit/d3c95f00d0ac14adcceb423173ff7106aa42d116
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)