Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] opencv3, opencv4: use openblasCompat #90259

Merged
merged 1 commit into from Nov 21, 2020
Merged

[20.03] opencv3, opencv4: use openblasCompat #90259

merged 1 commit into from Nov 21, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jun 13, 2020 •
edited

Motivation for this change

Without master's fix in #83888, opencv3 and opencv4 end up with an 8-byte openblas, which it does work with. However this causes the python bindings to also end up with an 8-byte openblas, which numpy doesn't work with. Force 4-byte openblas for opencv.

This is quite a big rebuild (for me, given my current setup), so I've only checked some key reverse dependencies (facedetect digikam gmic gimpPlugins.gmic python37Packages.vidstab gmic-qt) on linux x86_64 and macos 10.14.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor Author

risicle commented Jun 13, 2020

@GrahamcOfBorg build facedetect digikam gmic gimpPlugins.gmic python37Packages.vidstab gmic-qt quilter gnome3.shotwell caffe python38Packages.caffe

@risicle risicle force-pushed the ris-opencv-blas-compat-r20.03 branch from 2702f96 to e483ee1 Compare August 23, 2020 21:15
@risicle
Copy link
Contributor Author

risicle commented Aug 23, 2020 •
edited

rebased.
@ofborg build facedetect digikam gmic gimpPlugins.gmic python37Packages.vidstab gmic-qt quilter gnome3.shotwell caffe python38Packages.caffe

@risicle risicle changed the title [r20.03] opencv3, opencv4: use openblasCompat [20.03] opencv3, opencv4: use openblasCompat Aug 23, 2020
@SuperSandro2000
Copy link
Member

Friendly bump

@risicle
Copy link
Contributor Author

risicle commented Oct 25, 2020

Yup, just kinda waiting on a review from someone really...

@risicle
opencv3, opencv4: use openblasCompat
a10ebd8 
without master's fix in NixOS#83888, opencv3 & opencv4 end up with an 8-byte
openblas, which it does work with. however this causes the python
bindings to also end up with an 8-byte openblas, which numpy doesn't work
with. force 4-byte openblas for opencv.
@risicle risicle force-pushed the ris-opencv-blas-compat-r20.03 branch from e483ee1 to a10ebd8 Compare October 25, 2020 18:26
@risicle
Copy link
Contributor Author

risicle commented Oct 25, 2020

Rebased again.

@ofborg build facedetect digikam gmic gimpPlugins.gmic python37Packages.vidstab gmic-qt quilter gnome3.shotwell caffe python38Packages.caffe

@FRidh FRidh merged commit 8fdb672 into NixOS:release-20.03 Nov 21, 2020
@kevinmehall kevinmehall mentioned this pull request Oct 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdaiter mdaiter Awaiting requested review from mdaiter

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @SuperSandro2000 @FRidh