[20.03] opencv3, opencv4: use openblasCompat #90259
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build facedetect digikam gmic gimpPlugins.gmic python37Packages.vidstab gmic-qt quilter gnome3.shotwell caffe python38Packages.caffe |
risicle
force-pushed
the
ris-opencv-blas-compat-r20.03
branch
from
2702f96 to
e483ee1
Compare
|
rebased. |
risicle
changed the title
|
Friendly bump |
|
Yup, just kinda waiting on a review from someone really... |
without master's fix in NixOS#83888, opencv3 & opencv4 end up with an 8-byte openblas, which it does work with. however this causes the python bindings to also end up with an 8-byte openblas, which numpy doesn't work with. force 4-byte openblas for opencv.
risicle
force-pushed
the
ris-opencv-blas-compat-r20.03
branch
from
e483ee1 to
a10ebd8
Compare
|
Rebased again. @ofborg build facedetect digikam gmic gimpPlugins.gmic python37Packages.vidstab gmic-qt quilter gnome3.shotwell caffe python38Packages.caffe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Without
master's fix in #83888,opencv3andopencv4end up with an 8-byteopenblas, which it does work with. However this causes the python bindings to also end up with an 8-byteopenblas, whichnumpydoesn't work with. Force 4-byteopenblasforopencv.This is quite a big rebuild (for me, given my current setup), so I've only checked some key reverse dependencies (
facedetectdigikamgmicgimpPlugins.gmicpython37Packages.vidstabgmic-qt) on linux x86_64 and macos 10.14.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)