Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keepass #89393

Merged
merged 3 commits into from Jun 5, 2020
Merged

Keepass #89393

merged 3 commits into from Jun 5, 2020

Conversation

wnklmnn
Copy link
Contributor

@wnklmnn wnklmnn commented Jun 3, 2020

Motivation for this change

#88999
#88157 (review)

With my previous PR i broke the way keepass load plugins.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zimbatm
Copy link
Member

zimbatm commented Jun 3, 2020

can you fix the commit messages so they follow CONTRIBUTING.md? Add the keepass: pefix to the fix commits.

@Anton-Latukha
Copy link
Contributor

Anton-Latukha commented Jun 4, 2020 •
edited

When this would merge - it would allow people that use keepass-keeagent to update on nixos-unstable or nixpkgs-unstable, and so close #88999.

@zimbatm zimbatm merged commit 8db1c35 into NixOS:master Jun 5, 2020
@Anton-Latukha Anton-Latukha mentioned this pull request Jun 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wnklmnn @zimbatm @Anton-Latukha