Iterate sorted keys when comparing keyframes for testing #23946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 3, 2020
Since enumeration does not guarantee any specific order, we can get test failures when the order changes for an unrelated reason (typically when adding a new CSS property). Fix by sorting the keys before comparing, which ensures that we fail the same way every time. Change-Id: I7bbc8e98bc17120084c6934d71f092ee0ba016da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228724 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#774670}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2228724
branch
from
3f7a9b9
to
402e767
Compare
|
Pre-existing flakes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since enumeration does not guarantee any specific order, we can get
test failures when the order changes for an unrelated reason
(typically when adding a new CSS property).
Fix by sorting the keys before comparing, which ensures that we fail
the same way every time.
Change-Id: I7bbc8e98bc17120084c6934d71f092ee0ba016da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228724
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774670}