Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolate font-display wpt tests to subframes #23962

Closed
wants to merge 1 commit into from
Closed

Isolate font-display wpt tests to subframes #23962

wants to merge 1 commit into from

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 3, 2020 •
edited by stephenmcgruer

In order to unblock document policy violation report deduplication
implementation, it is necessary to separate subtests for font-display
wpt test into subframes so that their violation reports do not
interfere with each other.

Bug: 1087277
Change-Id: I79ece4fbaae2b28b40b85ca0a0df4daffd54bca0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227863
Reviewed-by: Jason Chase <chasej@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#775291}

Closed by @stephenmcgruer because the Chromium CL was reverted before this was landed. Revert:

Revert "Isolate font-display wpt tests to subframes"

This reverts commit 5b2b4b0c92a90ab92536897bfa5f0e06350d2865.

Reason for revert: Suspect this CL causes consistent build failure on 2 builders: Mac10.13 Tests (dbg) and Mac10.13 Tests (dbg)
First fail occurance:
https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/18725
https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/18725

TBR=chasej@chromium.org,chenleihu@google.com

Change-Id: I77f15471761bf62008d6de54f5197f4158211f95
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1087277
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230403
Reviewed-by: Maggie Cai <mxcai@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775413}

wpt-pr-bot
wpt-pr-bot approved these changes Jun 3, 2020
View reviewed changes
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2227863 branch 2 times, most recently from 4e2e9b7 to 62ebce6 Compare June 4, 2020 19:16
@chromium-wpt-export-bot
Isolate font-display wpt tests to subframes
6795752 
In order to unblock document policy violation report deduplication
implementation, it is necessary to separate subtests for font-display
wpt test into subframes so that their violation reports do not
interfere with each other.

Bug: 1087277
Change-Id: I79ece4fbaae2b28b40b85ca0a0df4daffd54bca0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227863
Reviewed-by: Jason Chase <chasej@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#775291}
@foolip foolip deleted the chromium-export-cl-2227863 branch April 14, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpt-pr-bot wpt-pr-bot wpt-pr-bot approved these changes

Assignees
No one assigned
Labels
chromium-export document-policy infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chromium-wpt-export-bot @wpt-pr-bot @stephenmcgruer