Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pulp: 2.0 -> 2.1 #89378

Merged
merged 1 commit into from Jun 3, 2020
Merged

pythonPackages.pulp: 2.0 -> 2.1 #89378

merged 1 commit into from Jun 3, 2020

Conversation

matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented Jun 3, 2020 •
edited

Motivation for this change

Update pulp to 2.1. This also allows me to use pulp+cbc, which I couldn't with v2.0.

Things done

I debated adding cbc as a buildInput since it's the default solver, but ultimately didn't. Let me know if this would be a good idea and I'll add it.

FYI: adding cbc as a checkInput got some of the tests working, but not all, so I've left it as false.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from teto June 3, 2020 00:30
jonringer
jonringer approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 89378 1

6 packages built:
- python27Packages.pulp
- python27Packages.pyschedule
- python37Packages.pulp
- python37Packages.pyschedule
- python38Packages.pulp
- python38Packages.pyschedule

@jonringer jonringer merged commit 1471767 into NixOS:master Jun 3, 2020
@matthuszagh matthuszagh deleted the pulp branch June 3, 2020 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@teto teto Awaiting requested review from teto

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthuszagh @jonringer