Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nativeio] NativeIO: Add Rename. #23941

Merged
merged 1 commit into from Jun 19, 2020
Merged

[nativeio] NativeIO: Add Rename. #23941

merged 1 commit into from Jun 19, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 3, 2020 •
edited

Bug: 914488
Change-Id: I81a96bc4f395d82d7a0c1d804eef25a861eb1fe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228152
Commit-Queue: Richard Stotz <rstz@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780220}

wpt-pr-bot
wpt-pr-bot approved these changes Jun 3, 2020
View reviewed changes
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2228152 branch 5 times, most recently from 587642c to 48dc293 Compare June 10, 2020 15:17
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2228152 branch 3 times, most recently from 64131f7 to 3e82589 Compare June 18, 2020 20:31
@rstz @chromium-wpt-export-bot
[nativeio] NativeIO: Add Rename.
c5c0a7c 
Bug: 914488
Change-Id: I81a96bc4f395d82d7a0c1d804eef25a861eb1fe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228152
Commit-Queue: Richard Stotz <rstz@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780220}
@KyleJu
Copy link
Contributor

KyleJu commented Jun 19, 2020

The following tests are unstable on chrome-dev

Test Subtest Results Messages
/native-io/rename_async_failure_handling.tentative.https.any.serviceworker.html ERROR: 1/5, OK: 4/5
/native-io/rename_async_failure_handling.tentative.https.any.serviceworker.html Failed nativeIO.rename does not unlock the destination. FAIL: 4/5, NOTRUN: 1/5 promise_test: Unhandled rejection with value: object "TypeError: nativeIO.rename is not a function"
/native-io/rename_async_failure_handling.tentative.https.any.sharedworker.html ERROR: 1/5, OK: 4/5
/native-io/rename_async_failure_handling.tentative.https.any.sharedworker.html Failed nativeIO.rename does not unlock the destination. FAIL: 4/5, NOTRUN: 1/5 `

@KyleJu
Copy link
Contributor

KyleJu commented Jun 19, 2020

Filed a bug https://bugs.chromium.org/p/chromium/issues/detail?id=1097126. Could you admin merge @Hexcles

@Hexcles Hexcles merged commit 81785c7 into master Jun 19, 2020
@Hexcles Hexcles deleted the chromium-export-cl-2228152 branch June 19, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpt-pr-bot wpt-pr-bot wpt-pr-bot approved these changes

Assignees
No one assigned
Labels
chromium-export native-io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chromium-wpt-export-bot @KyleJu @wpt-pr-bot @Hexcles @rstz