Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add travis configuration to run CI on github #113

Closed
wants to merge 2 commits into from

Conversation

staticfloat
Copy link

This travis CI configuration will automatically build and run the test suite of patchelf whenever a commit or pull request is made on Github. It uses the trusty container-based configuration to deploy patchelf and build it on an Ubuntu 14.04 container, since the version of autoconf required by patchelf is newer than that provided by the precise containers.

To enable travis on a github repository, go to https://travis-ci.org, login with Github and flip the switch for the NixOS/patchelf repository. Here's the getting started guide in case you have any questions.

I tested this configuration out on my own fork, you can see the result of this PR here.

This travis CI configuration will automatically build and run the test
suite of patchelf whenever a commit or pull request is made on Github.
It uses the `trusty` container-based configuration to deploy patchelf and
build it on an Ubuntu 14.04 container, since the version of autoconf
required by patchelf is newer than that provided by the `precise` containers.
@domenkozar
Copy link
Member

Tests are ran on http://hydra.nixos.org/jobset/patchelf/master, but we should probably denote that in README.

@staticfloat
Copy link
Author

Those tests also look much more comprehensive than those run on Travis.

On the other hand, it's somewhat opaque to outsiders, and makes it much more difficult for someone like me to determine whether my changes are working or not, whereas Travis (or other well-known CI services such as CircleCI) are pretty visible/transparent. Perhaps there's a way for hydra to run tests on PRs, that way we get the best of both worlds?

@domenkozar
Copy link
Member

this is now done

@domenkozar domenkozar closed this Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants