Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages: fix a bunch of broken packages #89376

Merged
merged 10 commits into from Jun 3, 2020
Merged

python3Packages: fix a bunch of broken packages #89376

merged 10 commits into from Jun 3, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jun 2, 2020 •
edited

Motivation for this change

fixes builds

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/89376
4 packages failed to build:
python27Packages.zope_i18n python37Packages.rl-coach python37Packages.zope_i18n python38Packages.zope_i18n

102 packages built:
buildbot buildbot-full buildbot-ui certbot cura devpi-client devpi-server gitAndTools.bump2version mailman octoprint python27Packages.celery python27Packages.clickclick python27Packages.connexion python27Packages.flower python27Packages.zope-hookable python27Packages.zope_component python27Packages.zope_configuration python27Packages.zope_i18nmessageid python27Packages.zope_lifecycleevent python27Packages.zope_size python37Packages.celery python37Packages.clickclick python37Packages.connexion python37Packages.cornice python37Packages.django-raster python37Packages.django-simple-captcha python37Packages.djmail python37Packages.flower python37Packages.mailman python37Packages.mailman-hyperkitty python37Packages.minio python37Packages.praw python37Packages.prawcore python37Packages.pyjade python37Packages.pyramid python37Packages.pyramid_beaker python37Packages.pyramid_chameleon python37Packages.pyramid_exclog python37Packages.pyramid_hawkauth python37Packages.pyramid_jinja2 python37Packages.pyramid_mako python37Packages.pyramid_multiauth python37Packages.scrapy python37Packages.sentry-sdk python37Packages.sopel python37Packages.stups-cli-support python37Packages.stups-fullstop python37Packages.stups-pierone python37Packages.stups-zign python37Packages.testfixtures python37Packages.zope-hookable python37Packages.zope_component python37Packages.zope_configuration python37Packages.zope_i18nmessageid python37Packages.zope_lifecycleevent python37Packages.zope_size python38Packages.buildbot python38Packages.buildbot-full python38Packages.buildbot-ui python38Packages.celery python38Packages.clickclick python38Packages.cornice python38Packages.django-raster python38Packages.django-simple-captcha python38Packages.djmail python38Packages.flower python38Packages.mailman python38Packages.mailman-hyperkitty python38Packages.minio python38Packages.praw python38Packages.prawcore python38Packages.pyjade python38Packages.pyramid python38Packages.pyramid_beaker python38Packages.pyramid_chameleon python38Packages.pyramid_exclog python38Packages.pyramid_hawkauth python38Packages.pyramid_jinja2 python38Packages.pyramid_mako python38Packages.pyramid_multiauth python38Packages.scrapy python38Packages.sopel python38Packages.stups-cli-support python38Packages.stups-fullstop python38Packages.stups-pierone python38Packages.stups-zign python38Packages.testfixtures python38Packages.zope-hookable python38Packages.zope_component python38Packages.zope_configuration python38Packages.zope_i18nmessageid python38Packages.zope_lifecycleevent python38Packages.zope_size sourcehut.buildsrht sourcehut.dispatchsrht sourcehut.gitsrht sourcehut.hgsrht sourcehut.listssrht sourcehut.mansrht sourcehut.metasrht sourcehut.pastesrht sourcehut.todosrht

@jonringer jonringer requested a review from FRidh as a code owner June 2, 2020 22:21
@ofborg ofborg bot requested a review from cillianderoiste June 3, 2020 04:35
@ofborg ofborg bot requested a review from elohmeier June 3, 2020 05:49
@ofborg ofborg bot requested a review from arnoldfarkas June 3, 2020 06:06
@jonringer jonringer changed the title python3Packages.zope-hookable: 4.2.0 -> 5.0.1 python3Packages: fix a bunch of broken packages Jun 3, 2020
@jonringer
Copy link
Contributor Author

fixes ~102 builds

@ofborg ofborg bot requested a review from nlewo June 3, 2020 07:07
@ofborg ofborg bot requested a review from makefu June 3, 2020 07:56
arnoldfarkas
arnoldfarkas reviewed Jun 3, 2020
View reviewed changes
pkgs/development/python-modules/celery/default.nix
--ignore=t/unit/concurrency/test_eventlet.py \
--ignore=t/unit/bin/test_multi.py \
--ignore=t/unit/apps/test_multi.py \
--ignore=t/unit/backends/test_mongodb.py
'';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cannot comment in the meta section below, so adding here.
would it worth adding a maintainer for this package?

arnoldfarkas
arnoldfarkas reviewed Jun 3, 2020
View reviewed changes
pkgs/development/python-modules/flower/default.nix
importlib-metadata
pytz
tornado
humanize
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[fancy]
should it go above pytz ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to sort, but it wasn't sorted before. I'm more concerned about the build failures than formatting :). doing small fixes on 10 different packages (and maintaining git practices) is a little painful

makefu
makefu approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@makefu makefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

devpi-client and devpi-server work as expected after running nix-review pr 89376 --package-regex devpi\*

thanks for your effort!

@jonringer
Copy link
Contributor Author

at the very least, this fixes some builds. If there's improvements to be made, they can be done in another PR

@jonringer jonringer merged commit 4ecc2d8 into NixOS:master Jun 3, 2020
@jonringer jonringer deleted the bump-zope-hook-able branch June 3, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@makefu makefu makefu approved these changes

@arnoldfarkas arnoldfarkas arnoldfarkas approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@elohmeier elohmeier Awaiting requested review from elohmeier

@WhittlesJr WhittlesJr Awaiting requested review from WhittlesJr

@abbradar abbradar Awaiting requested review from abbradar

@gebner gebner Awaiting requested review from gebner

@nlewo nlewo Awaiting requested review from nlewo

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonringer @Mic92 @makefu @arnoldfarkas