Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for non-queued acquisition mode in Oscilloscope::AcquireData() #132

Closed
azonenberg opened this issue Jun 2, 2020 · 2 comments
Closed

Remove support for non-queued acquisition mode in Oscilloscope::AcquireData() #132

azonenberg opened this issue Jun 2, 2020 · 2 comments
Assignees
@azonenberg
Labels
api API improvements

Comments

@azonenberg
Copy link
Collaborator

The current toQueue=true as default model seems to confuse people.

Maybe it makes more sense to define AcquireData() as only writing to the FIFO, then require a separate pop operation to read the data?

This isn't a final decision, looking for comments.
@azonenberg azonenberg added the api API improvements label Jun 2, 2020
@azonenberg azonenberg changed the title Consider removing support for non-queued acquisition mode in Oscilloscope() Consider removing support for non-queued acquisition mode in Oscilloscope::AcquireData() Jun 2, 2020
@noopwafel
Copy link
Collaborator

this would also simplify driver code, since it no longer has to special-case the first segment as "the one which might not go in the FIFO", so +1

@azonenberg azonenberg changed the title Consider removing support for non-queued acquisition mode in Oscilloscope::AcquireData() Remove support for non-queued acquisition mode in Oscilloscope::AcquireData() Aug 2, 2020
@azonenberg azonenberg self-assigned this Aug 2, 2020
@azonenberg
Copy link
Collaborator Author

Decision made, we're doing it. Might be a while before I get to it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azonenberg azonenberg

Labels
api API improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@azonenberg @noopwafel